Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:05 -0700, Satish Kumar Nagireddy wrote: > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Calling dmaengine_device_control() to terminate transfers is an internal > API that will disappear, use the stable API wrapper instead. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Satish Kumar Nagireddy <satish.nagireddy.nagireddy@xxxxxxxxxx> > --- > drivers/media/platform/xilinx/xilinx-dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/xilinx/xilinx-dma.c b/drivers/media/platform/xilinx/xilinx-dma.c > index cb20ada..a5bf345 100644 > --- a/drivers/media/platform/xilinx/xilinx-dma.c > +++ b/drivers/media/platform/xilinx/xilinx-dma.c > @@ -434,6 +434,7 @@ static int xvip_dma_start_streaming(struct vb2_queue *vq, unsigned int count) > return 0; > > error_stop: > + dmaengine_terminate_all(dma->dma); The patch and change are incorrectly mapped. The change adds dma termination on error, which doesn't match with patch description. And this API is deprecated. Please use dmaengine_terminate_sync() instead. Probably it makes sense to change another call of dmaengine_terminate_all() in this file. You can also do it in a separate patch. Up to you. Thanks, -hyun > media_pipeline_stop(&dma->video.entity); > > error: > -- > 2.1.1 >
