Hi Jacopo,
On Saturday, 28 April 2018 13:03:16 EEST jacopo mondi wrote:
> Hi Laurent,
> just one minor comment below
>
> On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote:
> > Add a parameter (in the form of a structure to ease future API
> > extensions) to the VSP atomic flush handler to pass CRC source
> > configuration, and pass the CRC value to the completion callback.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > ---
> >
> > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 6 ++++--
> > drivers/media/platform/vsp1/vsp1_drm.c | 6 ++++--
> > drivers/media/platform/vsp1/vsp1_drm.h | 2 +-
> > include/media/vsp1.h | 29 +++++++++++++++++++++++++++--
> > 4 files changed, 36 insertions(+), 7 deletions(-)
[snip]
> > diff --git a/include/media/vsp1.h b/include/media/vsp1.h
> > index ff7ef894465d..ac63a9928a79 100644
> > --- a/include/media/vsp1.h
> > +++ b/include/media/vsp1.h
[snip]
> > @@ -61,11 +61,36 @@ struct vsp1_du_atomic_config {
> > unsigned int zpos;
> > };
> >
> > +/**
> > + * enum vsp1_du_crc_source - Source used for CRC calculation
> > + * @VSP1_DU_CRC_NONE: CRC calculation disabled
> > + * @VSP_DU_CRC_PLANE: Perform CRC calculation on an input plane
> > + * @VSP_DU_CRC_OUTPUT: Perform CRC calculation on the composed output
>
> These two paramters are called VSP1_DU_CRC_* not VSP_DU_CRC_*
My bad. I've fixed this in my tree but will wait for other review comments
before posting a v3.
> > + */
> > +enum vsp1_du_crc_source {
> > + VSP1_DU_CRC_NONE,
> > + VSP1_DU_CRC_PLANE,
> > + VSP1_DU_CRC_OUTPUT,
> > +};
[snip]
--
Regards,
Laurent Pinchart
