Hi Kieran, On Saturday, 28 April 2018 00:25:51 EEST Kieran Bingham wrote: > Hi Laurent, > > Thank you for the patch, and going through the whole driver for this update. > On 22/04/18 23:34, Laurent Pinchart wrote: > > Adopt the SPDX license identifier headers to ease license compliance > > management. All files in the driver are licensed under the GPLv2+ except > > for the vsp1_regs.h file which is licensed under the GPLv2. This is > > likely an oversight, but fixing this requires contacting the copyright > > owners and is out of scope for this patch. > > I agree that's out of scope for this patch, but it's not too exhaustive a > list to correct at a later date: > > git shortlog -e -n -s -- ./drivers/media/platform/vsp1/vsp1_regs.h > 19 Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > 5 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@xxxxxxxxxxx> > 3 Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > 2 Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > 2 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > 1 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > 1 Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > 1 Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > (Both Geert and Linus are merge commits there) I agree with you, I've sent a separate patch. > > While at it fix the file descriptions to match file names where copy and > > paste error occurred. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > It's crazy that we have two types of comment style for the SPDX identifier - > but that's not a fault in this patch, so: > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > > --- > > > > drivers/media/platform/vsp1/vsp1.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_brx.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_brx.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_clu.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_clu.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_dl.c | 8 ++------ > > drivers/media/platform/vsp1/vsp1_dl.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_drm.c | 8 ++------ > > drivers/media/platform/vsp1/vsp1_drm.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_drv.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_entity.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_entity.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgo.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgo.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgt.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgt.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_histo.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_histo.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_hsit.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_hsit.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_lif.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_lif.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_lut.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_lut.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_pipe.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_pipe.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_regs.h | 5 +---- > > drivers/media/platform/vsp1/vsp1_rpf.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_rwpf.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_rwpf.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_sru.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_sru.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_uds.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_uds.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_video.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_video.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_wpf.c | 6 +----- > > 37 files changed, 39 insertions(+), 186 deletions(-) -- Regards, Laurent Pinchart
