Hi Yong,
On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi <yong.zhi@xxxxxxxxx> wrote:
[snip]
> +int ipu3_css_init(struct device *dev, struct ipu3_css *css,
> + void __iomem *base, int length)
> +{
> + int r, p, q, i;
> +
> + /* Initialize main data structure */
> + css->dev = dev;
> + css->base = base;
> + css->iomem_length = length;
> + css->current_binary = IPU3_CSS_DEFAULT_BINARY;
> + css->pipe_id = IPU3_CSS_PIPE_ID_NUM;
> + css->vf_output_en = IPU3_NODE_VF_DISABLED;
> + spin_lock_init(&css->qlock);
> +
> + for (q = 0; q < IPU3_CSS_QUEUES; q++) {
> + r = ipu3_css_queue_init(&css->queue[q], NULL, 0);
> + if (r)
> + return r;
> + }
> +
> + r = ipu3_css_fw_init(css);
> + if (r)
> + return r;
> +
> + /* Allocate and map common structures with imgu hardware */
> +
> + for (p = 0; p < IPU3_CSS_PIPE_ID_NUM; p++)
> + for (i = 0; i < IMGU_ABI_MAX_STAGES; i++) {
> + if (!ipu3_dmamap_alloc(dev,
> +
&css->xmem_sp_stage_ptrs[p][i],
> + sizeof(struct
imgu_abi_sp_stage)))
checkpatch reports line over 80 characters here.
> + goto error_no_memory;
> + if (!ipu3_dmamap_alloc(dev,
> +
&css->xmem_isp_stage_ptrs[p][i],
> + sizeof(struct
imgu_abi_isp_stage)))
Ditto.
> + goto error_no_memory;
> + }
Best regards,
Tomasz
