2018-04-24 0:54 GMT+09:00 Akinobu Mita <akinobu.mita@xxxxxxxxx>: > 2018-04-23 18:17 GMT+09:00 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>: >> Hi Mita-san, >> >> On Sunday, 22 April 2018 18:56:07 EEST Akinobu Mita wrote: >>> This adds a device tree binding documentation for OV7720/OV7725 sensor. >>> >>> Cc: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> >>> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >>> Cc: Hans Verkuil <hans.verkuil@xxxxxxxxx> >>> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >>> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> >>> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >>> Reviewed-by: Jacopo Mondi <jacopo@xxxxxxxxxx> >>> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> >>> --- >>> * v3 >>> - Add Reviewed-by: lines >>> >>> .../devicetree/bindings/media/i2c/ov772x.txt | 42 +++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 43 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov772x.txt >>> >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.txt >>> b/Documentation/devicetree/bindings/media/i2c/ov772x.txt new file mode >>> 100644 >>> index 0000000..b045503 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/i2c/ov772x.txt >>> @@ -0,0 +1,42 @@ >>> +* Omnivision OV7720/OV7725 CMOS sensor >>> + >>> +The Omnivision OV7720/OV7725 sensor supports multiple resolutions output, >>> +such as VGA, QVGA, and any size scaling down from CIF to 40x30. It also can >>> +support the YUV422, RGB565/555/444, GRB422 or raw RGB output formats. >>> + >>> +Required Properties: >>> +- compatible: shall be one of >>> + "ovti,ov7720" >>> + "ovti,ov7725" >>> +- clocks: reference to the xclk input clock. >>> +- clock-names: shall be "xclk". >> >> As there's a single clock we could omit clock-names, couldn't we ? > > Sounds good. > > I'll prepare another patch that replaces the clock consumer ID argument > of clk_get() from "xclk" to NULL, and remove the above line in this > bindings. I thought it's easy to do. However, there is a non-DT user (arch/sh/boards/mach-migor/setup.c) that defines a clock with "xclk" ID. This can be resolved by retrying clk_get() with NULL if no entry with "xclk". But should we do so or leave as is?
