On Wed, Apr 25, 2018 at 1:45 AM, Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > Store the group pointer before disassociating the VIN from the group. s/get/put/ in one-line summary? > Fixes: 3bb4c3bc85bf77a7 ("media: rcar-vin: add group allocator functions") > Reported-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > index 7bc2774a11232362..d3072e166a1ca24f 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -338,19 +338,21 @@ static int rvin_group_get(struct rvin_dev *vin) > > static void rvin_group_put(struct rvin_dev *vin) > { > - mutex_lock(&vin->group->lock); > + struct rvin_group *group = vin->group; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds