This was left over from the conversion to VB2, where the call was getting invoked both in buffer_queue and start_streaming, which was intermittently causing invalid opcodes on the VBI RISC queue. This change effectively mirrors the exact same change Hans Verkuil made in cx88-video.c in 389208e1173e097590856ed24a505551510f78d4. Thanks to Daniel Glöckner for spotting the actual bug after I spent several days trying to chase down the issue. Signed-off-by: Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> Thanks-to: Daniel Glöckner <daniel-gl@xxxxxxx> Cc: Hans Verkuil <hverkuil@xxxxxxxxx> --- drivers/media/pci/cx88/cx88-vbi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/cx88/cx88-vbi.c b/drivers/media/pci/cx88/cx88-vbi.c index c637679..58489ea 100644 --- a/drivers/media/pci/cx88/cx88-vbi.c +++ b/drivers/media/pci/cx88/cx88-vbi.c @@ -178,7 +178,6 @@ static void buffer_queue(struct vb2_buffer *vb) if (list_empty(&q->active)) { list_add_tail(&buf->list, &q->active); - cx8800_start_vbi_dma(dev, q, buf); dprintk(2, "[%p/%d] vbi_queue - first active\n", buf, buf->vb.vb2_buf.index); -- 1.9.1