Hi Mauro, On Thu, Apr 19, 2018 at 07:42:28AM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 18 Apr 2018 12:04:14 +0300 > Sakari Ailus <sakari.ailus@xxxxxx> escreveu: > > > On Tue, Apr 17, 2018 at 06:20:10AM -0400, Mauro Carvalho Chehab wrote: > > > There were several interactions at the COMPILE_TEST and smatch > > > patch series. While I applied most of them, there are 5 patches that > > > I kept out of it. The omap3 patch that were in my tree was the old > > > one. So, I'm re-posting it. > > > > > > The ioctl32 patches are the latest version. Let's repost it to get some > > > acks, as this patch touches at V4L2 core, so a careful review is > > > always a good idea. > > > > > > Arnd Bergmann (1): > > > media: omap3isp: allow it to build with COMPILE_TEST > > > > > > Laurent Pinchart (1): > > > media: omap3isp: Enable driver compilation on ARM with COMPILE_TEST > > > > > > Mauro Carvalho Chehab (3): > > > omap: omap-iommu.h: allow building drivers with COMPILE_TEST > > > media: v4l2-compat-ioctl32: fix several __user annotations > > > media: v4l2-compat-ioctl32: better name userspace pointers > > > > > > drivers/media/platform/Kconfig | 7 +- > > > drivers/media/platform/omap3isp/isp.c | 8 + > > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 623 +++++++++++++------------- > > > include/linux/omap-iommu.h | 5 + > > > 4 files changed, 338 insertions(+), 305 deletions(-) > > > > For patches 1 and 2: > > > > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > What about patch 3? > > > > > I'd like to see a new versions of patches 4 and 5; I agree on the naming > > change. > > With what changes? Hans had comments on patch 5 at least (moving changes to 3rd patch), that may affect 4th patch as well. > > > Could you set the To: header to a valid value going forward? It's not a > > valid e-mail address but still contains "<" character which causes trouble > > when replying to the patches. > > I've no idea how to fix it. When I submit patches, I don't add any To: > header (as the "to" is meant to be the one that will apply the patches... > sending an e-mail to myself seems too mad for my taste). Somewhere > between git-send-email, my SMTP local host or the SMTP smart gateway, > or something afterwards, a "fake" To: gets introduced. To header isn't about who is going to apply the patches but who they concern the most. How about addressing the mail to the linux-media list? That's what everyone else does, unless they are sending the patches to certain recipients, which they could do for a number of reasons. The invalid To: header effectively leads to unintentional off-list discussion. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx
