On 04/10/2018 07:26 AM, Tomasz Figa wrote:
> Hi Hans,
>
> On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>
>> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
>> Define the public request API.
>
>> This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request
>> and two ioctls that operate on a request in order to queue the
>> contents of the request to the driver and to re-initialize the
>> request.
>
>> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>> ---
>> include/uapi/linux/media.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
>> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
>> index c7e9a5cba24e..f8769e74f847 100644
>> --- a/include/uapi/linux/media.h
>> +++ b/include/uapi/linux/media.h
>> @@ -342,11 +342,19 @@ struct media_v2_topology {
>
>> /* ioctls */
>
>> +struct __attribute__ ((packed)) media_request_alloc {
>> + __s32 fd;
>> +};
>> +
>> #define MEDIA_IOC_DEVICE_INFO _IOWR('|', 0x00, struct media_device_info)
>> #define MEDIA_IOC_ENUM_ENTITIES _IOWR('|', 0x01, struct
> media_entity_desc)
>> #define MEDIA_IOC_ENUM_LINKS _IOWR('|', 0x02, struct media_links_enum)
>> #define MEDIA_IOC_SETUP_LINK _IOWR('|', 0x03, struct media_link_desc)
>> #define MEDIA_IOC_G_TOPOLOGY _IOWR('|', 0x04, struct media_v2_topology)
>> +#define MEDIA_IOC_REQUEST_ALLOC _IOWR('|', 0x05, struct
> media_request_alloc)
>> +
>> +#define MEDIA_REQUEST_IOC_QUEUE _IO('|', 0x80)
>> +#define MEDIA_REQUEST_IOC_REINIT _IO('|', 0x81)
>
> I wonder if it wouldn't make sense to add a comment here saying that these
> are called on request FD, as opposed to the others above, which are called
> on the media FD.
Added.
Hans
>
> Best regards,
> Tomasz
>
