On Thursday, April 05, 2018 04:29:42 PM Mauro Carvalho Chehab wrote: > This driver builds cleanly with COMPILE_TEST, and it is > needed in order to allow building drivers/media omap2 > driver. > > So, change the logic there to allow building it. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> This change has broken build on OF=n && COMPILE_TEST=y configs: https://patchwork.kernel.org/patch/10352465/ [ This is not a problem when compiling for OMAP2 because it depends on ARM Multiplatform support which (indirectly) selects OF. ] Also I would really prefer that people won't merge fbdev related patches without my ACK and I see this patch in -next coming from one of your trees.. > --- > drivers/video/fbdev/omap2/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig > index 0921c4de8407..82008699d253 100644 > --- a/drivers/video/fbdev/omap2/Kconfig > +++ b/drivers/video/fbdev/omap2/Kconfig > @@ -1,4 +1,4 @@ > -if ARCH_OMAP2PLUS > +if ARCH_OMAP2PLUS || COMPILE_TEST > > source "drivers/video/fbdev/omap2/omapfb/Kconfig" Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
