On Fri, 20 Apr 2018 14:32:15 +0200, Mauro Carvalho Chehab wrote: > > All sound drivers that don't depend on PNP can be safelly > build with COMPILE_TEST, as ISA provides function stubs to > be used for such purposes. > > As a side effect, with this change, the radio-miropcm20 > can now be built outside i386 with COMPILE_TEST. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > --- > drivers/media/radio/Kconfig | 3 ++- > sound/isa/Kconfig | 9 +++++---- > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index d363726e9eb1..8fa403c7149e 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -372,7 +372,8 @@ config RADIO_GEMTEK_PROBE > > config RADIO_MIROPCM20 > tristate "miroSOUND PCM20 radio" > - depends on ISA && ISA_DMA_API && VIDEO_V4L2 && SND > + depends on ISA || COMPILE_TEST > + depends on ISA_DMA_API && VIDEO_V4L2 && SND > select SND_ISA > select SND_MIRO > ---help--- > diff --git a/sound/isa/Kconfig b/sound/isa/Kconfig > index cb54d9c0a77f..d2a6cdd0395c 100644 > --- a/sound/isa/Kconfig > +++ b/sound/isa/Kconfig > @@ -20,7 +20,8 @@ config SND_SB16_DSP > > menuconfig SND_ISA > bool "ISA sound devices" > - depends on ISA && ISA_DMA_API > + depends on ISA || COMPILE_TEST > + depends on ISA_DMA_API > default y > help > Support for sound devices connected via the ISA bus. > @@ -38,7 +39,7 @@ config SND_ADLIB > > config SND_AD1816A > tristate "Analog Devices SoundPort AD1816A" > - depends on PNP > + depends on PNP && ISA > select ISAPNP > select SND_OPL3_LIB > select SND_MPU401_UART Just from curiosity: what's the reason for this explicit CONFIG_ISA dependency? What error did you get? thanks, Takashi > @@ -66,7 +67,7 @@ config SND_AD1848 > > config SND_ALS100 > tristate "Diamond Tech. DT-019x and Avance Logic ALSxxx" > - depends on PNP > + depends on PNP && ISA > select ISAPNP > select SND_OPL3_LIB > select SND_MPU401_UART > @@ -107,7 +108,7 @@ config SND_AZT2316 > > config SND_AZT2320 > tristate "Aztech Systems AZT2320" > - depends on PNP > + depends on PNP && ISA > select ISAPNP > select SND_OPL3_LIB > select SND_MPU401_UART > -- > 2.14.3 > >
