Hi Sakari,
On Fri, Apr 13, 2018 at 03:14:37PM +0300, Sakari Ailus wrote:
> > +static int csi2tx_set_pad_format(struct v4l2_subdev *subdev,
> > + struct v4l2_subdev_pad_config *cfg,
> > + struct v4l2_subdev_format *fmt)
> > +{
> > + struct csi2tx_priv *csi2tx = v4l2_subdev_to_csi2tx(subdev);
> > +
> > + if (fmt->pad >= CSI2TX_PAD_MAX)
> > + return -EINVAL;
> > +
> > + csi2tx->pad_fmts[fmt->pad] = fmt->format;
>
> Have I asked previously if there are any limitations with this?
>
> The CSI-2 TX link has multiple formats so I wouldn't support formats on
> that pad in order to be compatible with the planned VC/data type support
> patchset. Or do you see issues with that?
It's not just about the CSI-2 link, but more about the input pads as
well, that can be configured (and we need to know the format in order
to configure the IP properly).
Maybe we can simply prevent the format change on the CSI-2 pad, but
not the others?
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
