On Tue, Apr 17, 2018 at 10:34 AM, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > Hi Ibtsam, > > On Tue, 2018-04-17 at 09:26 +0200, Ibtsam Ul-Haq wrote: >> On Mon, Apr 16, 2018 at 11:30 AM, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: >> > On Mon, 2018-04-16 at 09:54 +0200, Ibtsam Ul-Haq wrote: >> > [...] >> > > This indeed looks the case. But then, is 'GR16' the FourCC for 'SGRBG16'? >> > >> > Yes, see Documentation/media/uapi/v4l/pixfmt-srggb16.rst: >> > https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/pixfmt-srggb16.html >> > >> > > To be honest, I had not seen GR16 as FourCC before. >> > > And the Gstreamer debug logs (I used GST_DEBUG=5) also say that they >> > > do not know this FourCC: >> > > v4l2 gstv4l2object.c:1541:gst_v4l2_object_v4l2fourcc_to_bare_struct: [00m >> > > Unsupported fourcc 0x36315247 GR16 >> > >> > The GStreamer V4L2 elements currently only support 8-bit per component >> > Bayer formats. >> > >> > > Is there a way we can get by this? >> > >> > There's two ways to handle this correctly, IMHO. One would be adding >> > SGRBG8_1X8 support to the mt9p031 driver. This is the correct way if the >> > device tree is configured for 8-bit parallel and there are only 8 data >> > lines connected between camera and SoC. As a quick hack, I think you >> > could just: >> > >> > sed "s/MEDIA_BUS_FMT_SGRBG12_1X12/MEDIA_BUS_FMT_SGRBG8_1X8/" -i drivers/media/i2c/mt9p031.c >> > >> >> >> I tried that and it works well for my case. All pads in the pipeline >> now report their format as SGRBG8_1X8. >> >> However, now I am getting a Broken Pipe error from STREAMON when I try >> to run the pipeline: >> v4l2bufferpool gstv4l2bufferpool.c:677:gst_v4l2_buffer_pool_streamon:<v4l2src0:pool:src> >> [00m >> error with STREAMON 32 (Broken pipe) > > What about format width and height, are they the same throughout the > pipeline? It didn't look that way in your last mail. > Indeed they were not the same. That was probably because the default window width and height were 2592x1944. So when I tried to set resolution to 640x480, it actually became 648x486, and the ipu1_csi0 expanded it to 656x486. I have that changed now, so the pads now look to have the same width and height: :~# media-ctl --get-v4l2 "'mt9p031 0-0048':0" [fmt:SGRBG8_1X8/640x480 field:none colorspace:srgb crop:(16,54)/2560x1920] :~# media-ctl --get-v4l2 "'mt9p031 0-0048':0" [fmt:SGRBG8_1X8/640x480 field:none colorspace:srgb crop:(16,54)/2560x1920] :~# media-ctl --get-v4l2 "'ipu1_csi0_mux':1" [fmt:SGRBG8_1X8/640x480 field:none colorspace:srgb] :~# media-ctl --get-v4l2 "'ipu1_csi0_mux':2" [fmt:SGRBG8_1X8/640x480 field:none colorspace:srgb] :~# media-ctl --get-v4l2 "'ipu1_csi0':0" [fmt:SGRBG8_1X8/640x480@1/30 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range crop.bounds:(0,0)/640x480 crop:(0,0)/640x480 compose.bounds:(0,0)/640x480 compose:(0,0)/640x480] :~# media-ctl --get-v4l2 "'ipu1_csi0':2" [fmt:SGRBG8_1X8/640x480@1/30 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range] But now I am getting: gst_v4l2_buffer_pool_poll (): /GstPipeline:pipeline0/GstV4l2Src:v4l2src0: poll error 1: Invalid argument (22) This is accompanied by dmesg errors: [ 8056.756841] alloc_contig_range: [80400, 80496) PFNs busy [ 8057.833501] ipu1_csi0: EOF timeout [ 8058.953717] ipu1_csi0: wait last EOF timeout It looks like there is some problem with memory allocation. >> >> I also get a corresponding error on the dmesg: >> [ 1398.723524] ipu1_csi0: pipeline start failed with -32 > > That is the same issue. I assume link validation fails with -EPIPE > because frame dimensions differ between some connected source and sink > pad. If you have dynamic debug enabled, you can verify this by enabling > the relevant debug printks in drivers/media: > > echo "func __media_pipeline_start +p" > /sys/kernel/debug/dynamic_debug/control > > This will show exactly which link causes the failure: > > imx-media capture-subsystem: link validation failed for 'ipu1_csi0_mux':2 -> 'ipu1_csi0':0, error -32 > ipu1_csi0: pipeline start failed with -32 > > Here width and height were different between connected source and sink > pad: > > media-ctl --get-v4l2 "'ipu1_csi0_mux':2" > [fmt:UYVY8_1X16/640x480 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range] > > media-ctl --get-v4l2 "'ipu1_csi0':0" > [fmt:UYVY8_1X16/1920x1080@1/60 field:none colorspace:rec709 xfer:709 ycbcr:709 quantization:lim-range > crop.bounds:(0,0)/1920x1080 > crop:(0,0)/1920x1080 > compose.bounds:(0,0)/1920x1080 > compose:(0,0)/1920x1080] > > If you look at v4l2_subdev_link_validate_default in > drivers/media/v4l2-core/v4l2-subdev.c, you can see that besides the > format code, it also checks width, height, and field setting. > > regards > Philipp Best regards, Ibtsam Haq
