Hi Luca, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180413] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Ceresoli/imx274-add-cropping-and-misc-improvements/20180413-234459 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x017-201814 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:329:0, from include/linux/kernel.h:14, from include/linux/clk.h:16, from drivers/media/i2c/imx274.c:22: drivers/media/i2c/imx274.c: In function 'imx274_s_stream': >> drivers/media/i2c/imx274.c:1027:32: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'int' [-Wformat=] dev_dbg(&imx274->client->dev, "%s : %s, mode index %lu\n", __func__, ^ drivers/media/i2c/imx274.c:1029:3: imx274->mode - &imx274_formats[0]); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg' __dynamic_dev_dbg(&descriptor, dev, fmt, \ ^~~ >> drivers/media/i2c/imx274.c:1027:2: note: in expansion of macro 'dev_dbg' dev_dbg(&imx274->client->dev, "%s : %s, mode index %lu\n", __func__, ^~~~~~~ vim +1027 drivers/media/i2c/imx274.c 1011 1012 /** 1013 * imx274_s_stream - It is used to start/stop the streaming. 1014 * @sd: V4L2 Sub device 1015 * @on: Flag (True / False) 1016 * 1017 * This function controls the start or stop of streaming for the 1018 * imx274 sensor. 1019 * 1020 * Return: 0 on success, errors otherwise 1021 */ 1022 static int imx274_s_stream(struct v4l2_subdev *sd, int on) 1023 { 1024 struct stimx274 *imx274 = to_imx274(sd); 1025 int ret = 0; 1026 > 1027 dev_dbg(&imx274->client->dev, "%s : %s, mode index %lu\n", __func__, 1028 on ? "Stream Start" : "Stream Stop", 1029 imx274->mode - &imx274_formats[0]); 1030 1031 mutex_lock(&imx274->lock); 1032 1033 if (on) { 1034 /* load mode registers */ 1035 ret = imx274_mode_regs(imx274); 1036 if (ret) 1037 goto fail; 1038 1039 /* 1040 * update frame rate & expsoure. if the last mode is different, 1041 * HMAX could be changed. As the result, frame rate & exposure 1042 * are changed. 1043 * gain is not affected. 1044 */ 1045 ret = imx274_set_frame_interval(imx274, 1046 imx274->frame_interval); 1047 if (ret) 1048 goto fail; 1049 1050 /* update exposure time */ 1051 ret = __v4l2_ctrl_s_ctrl(imx274->ctrls.exposure, 1052 imx274->ctrls.exposure->val); 1053 if (ret) 1054 goto fail; 1055 1056 /* start stream */ 1057 ret = imx274_start_stream(imx274); 1058 if (ret) 1059 goto fail; 1060 } else { 1061 /* stop stream */ 1062 ret = imx274_write_table(imx274, imx274_stop); 1063 if (ret) 1064 goto fail; 1065 } 1066 1067 mutex_unlock(&imx274->lock); 1068 dev_dbg(&imx274->client->dev, "%s : Done\n", __func__); 1069 return 0; 1070 1071 fail: 1072 mutex_unlock(&imx274->lock); 1073 dev_err(&imx274->client->dev, "s_stream failed\n"); 1074 return ret; 1075 } 1076 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
