Em Fri, 06 Apr 2018 18:46:05 +0300 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 6 April 2018 17:23:18 EEST Mauro Carvalho Chehab wrote: > > Instead of converting to int, use %p. That prevents this > > warning: > > drivers/media/platform/omap3isp/ispstat.c:451 isp_stat_bufs_alloc() warn: > > argument 7 to %08lx specifier is cast from pointer > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > > --- > > drivers/media/platform/omap3isp/ispstat.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/platform/omap3isp/ispstat.c > > b/drivers/media/platform/omap3isp/ispstat.c index > > 47cbc7e3d825..eb1b589b0aeb 100644 > > --- a/drivers/media/platform/omap3isp/ispstat.c > > +++ b/drivers/media/platform/omap3isp/ispstat.c > > @@ -449,10 +449,10 @@ static int isp_stat_bufs_alloc(struct ispstat *stat, > > u32 size) buf->empty = 1; > > > > dev_dbg(stat->isp->dev, > > - "%s: buffer[%u] allocated. dma=0x%08lx virt=0x%08lx", > > + "%s: buffer[%u] allocated. dma=0x%08lx virt=%p", > > stat->subdev.name, i, > > (unsigned long)buf->dma_addr, > > - (unsigned long)buf->virt_addr); > > + buf->virt_addr); > > While at it you can use %pad for buf->dma_addr. > > dev_dbg(stat->isp->dev, > "%s: buffer[%u] allocated. dma=%pad virt=%p", > stat->subdev.name, i, &buf->dma_addr, buf->virt_addr); > > With that change, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > } > > > > return 0; > OK. New patch enclosed. Thanks, Mauro [PATCH] media: ispstat: use %p to print the address of a buffer Instead of converting to int, use %p. That prevents this warning: drivers/media/platform/omap3isp/ispstat.c:451 isp_stat_bufs_alloc() warn: argument 7 to %08lx specifier is cast from pointer Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index 47cbc7e3d825..0b31f6c5791f 100644 --- a/drivers/media/platform/omap3isp/ispstat.c +++ b/drivers/media/platform/omap3isp/ispstat.c @@ -449,10 +449,8 @@ static int isp_stat_bufs_alloc(struct ispstat *stat, u32 size) buf->empty = 1; dev_dbg(stat->isp->dev, - "%s: buffer[%u] allocated. dma=0x%08lx virt=0x%08lx", - stat->subdev.name, i, - (unsigned long)buf->dma_addr, - (unsigned long)buf->virt_addr); + "%s: buffer[%u] allocated. dma=%pad virt=%p", + stat->subdev.name, i, &buf->dma_addr, buf->virt_addr); } return 0;
