Hi Ian, On Fri, 2018-04-06 at 09:40 +0100, Ian Arkver wrote: > > - ret = coda_try_fmt_vid_cap(file, priv, &f_cap); > > - if (ret) > > - return ret; > > - > > - q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); > > - r.left = 0; > > - r.top = 0; > > - r.width = q_data_src->width; > > - r.height = q_data_src->height; > > - > > - return coda_s_fmt(ctx, &f_cap, &r); > > + return coda_s_fmt_vid_cap(file, priv, &f_cap); > > Is this chunk (and removal of q_data_src above) part of the same patch? > It doesn't seem covered by the subject line. You are right, I'll move this into a separate patch. thanks Philipp