Em Fri, 6 Apr 2018 16:37:15 +0200 Arnd Bergmann <arnd@xxxxxxxx> escreveu: > On Fri, Apr 6, 2018 at 4:26 PM, Mauro Carvalho Chehab > <mchehab@xxxxxxxxxxxxxxxx> wrote: > > Em Fri, 6 Apr 2018 16:16:46 +0200 > > Arnd Bergmann <arnd@xxxxxxxx> escreveu: > > > >> On Fri, Apr 6, 2018 at 4:15 PM, Mauro Carvalho Chehab > >> <mchehab@xxxxxxxxxxxxxxxx> wrote: > >> > Em Fri, 6 Apr 2018 11:51:16 +0200 > >> > Arnd Bergmann <arnd@xxxxxxxx> escreveu: > >> > > >> >> On Fri, Apr 6, 2018 at 11:47 AM, Mauro Carvalho Chehab > >> >> <mchehab@xxxxxxxxxxxxxxxx> wrote: > >> >> > >> >> > [PATCH] media: fsl-viu: allow building it with COMPILE_TEST > >> >> > > >> >> > There aren't many things that would be needed to allow it > >> >> > to build with compile test. > >> >> > > >> >> > Add the needed bits. > >> >> > > >> >> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > >> >> > >> >> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > >> > > >> > Actually, in order to avoid warnings with smatch, the COMPILE_TEST > >> > macros should be declared as: > >> > > >> > +#define out_be32(v, a) iowrite32be(a, (void __iomem *)v) > >> > +#define in_be32(a) ioread32be((void __iomem *)a) > >> > >> I would just add the correct annotations, I think they've always been missing. > >> 2 patches coming in a few minutes. > > > > I corrected the annotations too. Now, it gives the same results > > building for both arm and x86. > > > > If you want to double check, the full tree is at: > > > > https://git.linuxtv.org/mchehab/experimental.git/log/?h=compile_test > > The __iomem annotations look good, my other patch is still needed to > get a clean build with "make C=1" but doesn't apply cleanly on top of your > version. I assume you'll just fix it up accordingly. Heh, another duplicated patch: https://git.linuxtv.org/mchehab/experimental.git/commit/?h=compile_test&id=687520dc31a88c82c694492423c5d9c503cbdebb That's why it didn't apply cleanly: $ patch -p1 -i /tmp/media\:\ platform\:\ fsl-viu\:\ mark\ local\ functions\ \'static\'.patch --merge patching file drivers/media/platform/fsl-viu.c Hunk #1 already applied at 238. Hunk #2 already applied at 251. Hunk #3 already applied at 262. Hunk #4 already applied at 806. Hunk #5 already applied at 817. Hunk #6 already applied at 1305. Great minds think alike :-) Thanks, Mauro
