On Fri, Mar 23, 2018 at 12:14:19PM +0800, Todor Tomov wrote: > Add the document for ov7251 device tree binding. > > CC: Rob Herring <robh@xxxxxxxxxx> > CC: Mark Rutland <mark.rutland@xxxxxxx> > CC: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Todor Tomov <todor.tomov@xxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > --- > .../devicetree/bindings/media/i2c/ov7251.txt | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov7251.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov7251.txt b/Documentation/devicetree/bindings/media/i2c/ov7251.txt > new file mode 100644 > index 0000000..4ee6888 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov7251.txt > @@ -0,0 +1,51 @@ > +* Omnivision 1/7.5-Inch B&W VGA CMOS Digital Image Sensor > + > +The Omnivision OV7251 is a 1/7.5-Inch CMOS active pixel digital image sensor with > +an active array size of 640H x 480V. It is programmable through a serial I2C > +interface. > + > +Required Properties: > +- compatible: Value should be "ovti,ov7251". > +- clocks: Reference to the xclk clock. > +- clock-names: Should be "xclk". > +- clock-frequency: Frequency of the xclk clock. > +- enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds > + to the hardware pin XSHUTDOWN which is physically active low. > +- vdddo-supply: Chip digital IO regulator. > +- vdda-supply: Chip analog regulator. > +- vddd-supply: Chip digital core regulator. > + > +The device node must contain one 'port' child node for its digital output Could you add there shall be a single endpoint node in the port node as well? > +video port, in accordance with the video interface bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +Example: > + > + &i2c1 { > + ... > + > + ov7251: camera-sensor@60 { > + compatible = "ovti,ov7251"; > + reg = <0x60>; > + > + enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&camera_bw_default>; > + > + clocks = <&clks 200>; > + clock-names = "xclk"; > + clock-frequency = <24000000>; > + > + vdddo-supply = <&camera_dovdd_1v8>; > + vdda-supply = <&camera_avdd_2v8>; > + vddd-supply = <&camera_dvdd_1v2>; > + > + port { > + ov7251_ep: endpoint { > + clock-lanes = <1>; > + data-lanes = <0>; > + remote-endpoint = <&csi0_ep>; > + }; > + }; > + }; > + }; > -- > 2.7.4 > -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx