On 28/03/18 13:27, Kieran Bingham wrote: > Hi Laurent, > > Thank you for the patch. > > On 26/02/18 21:45, Laurent Pinchart wrote: >> The entities in the pipeline are all started when the LIF is setup. >> Remove the outdated comment that state otherwise. >> >> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > I'll start with the easy ones :-) In fact, couldn't this patch be squashed into [PATCH 01/15] in this series ? -- Kieran > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > >> --- >> drivers/media/platform/vsp1/vsp1_drm.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/media/platform/vsp1/vsp1_drm.c b/drivers/media/platform/vsp1/vsp1_drm.c >> index e31fb371eaf9..a1f2ba044092 100644 >> --- a/drivers/media/platform/vsp1/vsp1_drm.c >> +++ b/drivers/media/platform/vsp1/vsp1_drm.c >> @@ -221,11 +221,7 @@ int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index, >> return -EPIPE; >> } >> >> - /* >> - * Enable the VSP1. We don't start the entities themselves right at this >> - * point as there's no plane configured yet, so we can't start >> - * processing buffers. >> - */ >> + /* Enable the VSP1. */ >> ret = vsp1_device_get(vsp1); >> if (ret < 0) >> return ret; >>
