Re: [PATCH v4] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Akihiro,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc7 next-20180328]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/tskd08-gmail-com/dvb-usb-friio-dvb-usb-v2-gl861-decompose-friio-and-merge-with-gl861/20180329-001436
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x019-201812 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/media/usb/dvb-usb-v2/gl861.c:203:24: error: field 'tuner_cfg' has incomplete type
     struct dvb_pll_config tuner_cfg;
                           ^~~~~~~~~
>> drivers/media/usb/dvb-usb-v2/gl861.c:210:3: error: field name not in record or union initializer
      .desc_id = DVB_PLL_TUA6034_FRIIO,
      ^
   drivers/media/usb/dvb-usb-v2/gl861.c:210:3: note: (near initialization for 'friio_config.tuner_cfg')
>> drivers/media/usb/dvb-usb-v2/gl861.c:210:14: error: 'DVB_PLL_TUA6034_FRIIO' undeclared here (not in a function); did you mean 'DVB_PLL_TUA6034'?
      .desc_id = DVB_PLL_TUA6034_FRIIO,
                 ^~~~~~~~~~~~~~~~~~~~~
                 DVB_PLL_TUA6034
   drivers/media/usb/dvb-usb-v2/gl861.c: In function 'friio_tuner_attach':
>> drivers/media/usb/dvb-usb-v2/gl861.c:414:24: error: storage size of 'cfg' isn't known
     struct dvb_pll_config cfg;
                           ^~~
   drivers/media/usb/dvb-usb-v2/gl861.c:414:24: warning: unused variable 'cfg' [-Wunused-variable]

vim +/tuner_cfg +203 drivers/media/usb/dvb-usb-v2/gl861.c

   197	
   198	struct friio_config {
   199		struct i2c_board_info demod_info;
   200		struct tc90522_config demod_cfg;
   201	
   202		struct i2c_board_info tuner_info;
 > 203		struct dvb_pll_config tuner_cfg;
   204	};
   205	
   206	static const struct friio_config friio_config = {
   207		.demod_info = { I2C_BOARD_INFO(TC90522_I2C_DEV_TER, 0x18), },
   208		.tuner_info = { I2C_BOARD_INFO("dvb_pll", 0x60), },
   209		.tuner_cfg = {
 > 210			.desc_id = DVB_PLL_TUA6034_FRIIO,
   211		},
   212	};
   213	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux