tree: git://git.ragnatech.se/linux media-tree
head: 238f694e1b7f8297f1256c57e41f69c39576c9b4
commit: 227b183dcbcc430a6ce29518d3b24d481597e87d [312/369] media: ov13858: Use v4l2_find_nearest_size
config: i386-randconfig-i0-03221101 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 227b183dcbcc430a6ce29518d3b24d481597e87d
# save the attached .config to linux build tree
make ARCH=i386
Note: the ragnatech/media-tree HEAD 238f694e1b7f8297f1256c57e41f69c39576c9b4 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/media/i2c/ov13858.c: In function 'ov13858_set_pad_format':
drivers/media/i2c/ov13858.c:1379:48: error: macro "v4l2_find_nearest_size" requires 6 arguments, but only 5 given
fmt->format.width, fmt->format.height);
^
>> drivers/media/i2c/ov13858.c:1378:9: error: 'v4l2_find_nearest_size' undeclared (first use in this function); did you mean '__v4l2_find_nearest_size'?
mode = v4l2_find_nearest_size(supported_modes, width, height,
^~~~~~~~~~~~~~~~~~~~~~
__v4l2_find_nearest_size
drivers/media/i2c/ov13858.c:1378:9: note: each undeclared identifier is reported only once for each function it appears in
vim +1378 drivers/media/i2c/ov13858.c
1357
1358 static int
1359 ov13858_set_pad_format(struct v4l2_subdev *sd,
1360 struct v4l2_subdev_pad_config *cfg,
1361 struct v4l2_subdev_format *fmt)
1362 {
1363 struct ov13858 *ov13858 = to_ov13858(sd);
1364 const struct ov13858_mode *mode;
1365 struct v4l2_mbus_framefmt *framefmt;
1366 s32 vblank_def;
1367 s32 vblank_min;
1368 s64 h_blank;
1369 s64 pixel_rate;
1370 s64 link_freq;
1371
1372 mutex_lock(&ov13858->mutex);
1373
1374 /* Only one raw bayer(GRBG) order is supported */
1375 if (fmt->format.code != MEDIA_BUS_FMT_SGRBG10_1X10)
1376 fmt->format.code = MEDIA_BUS_FMT_SGRBG10_1X10;
1377
> 1378 mode = v4l2_find_nearest_size(supported_modes, width, height,
> 1379 fmt->format.width, fmt->format.height);
1380 ov13858_update_pad_format(mode, fmt);
1381 if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
1382 framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
1383 *framefmt = fmt->format;
1384 } else {
1385 ov13858->cur_mode = mode;
1386 __v4l2_ctrl_s_ctrl(ov13858->link_freq, mode->link_freq_index);
1387 link_freq = link_freq_menu_items[mode->link_freq_index];
1388 pixel_rate = link_freq_to_pixel_rate(link_freq);
1389 __v4l2_ctrl_s_ctrl_int64(ov13858->pixel_rate, pixel_rate);
1390
1391 /* Update limits and set FPS to default */
1392 vblank_def = ov13858->cur_mode->vts_def -
1393 ov13858->cur_mode->height;
1394 vblank_min = ov13858->cur_mode->vts_min -
1395 ov13858->cur_mode->height;
1396 __v4l2_ctrl_modify_range(
1397 ov13858->vblank, vblank_min,
1398 OV13858_VTS_MAX - ov13858->cur_mode->height, 1,
1399 vblank_def);
1400 __v4l2_ctrl_s_ctrl(ov13858->vblank, vblank_def);
1401 h_blank =
1402 link_freq_configs[mode->link_freq_index].pixels_per_line
1403 - ov13858->cur_mode->width;
1404 __v4l2_ctrl_modify_range(ov13858->hblank, h_blank,
1405 h_blank, 1, h_blank);
1406 }
1407
1408 mutex_unlock(&ov13858->mutex);
1409
1410 return 0;
1411 }
1412
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
