Okay. All comments are addressed in v7. (https://patchwork.linuxtv.org/patch/47869/) Thanks for all the comments and suggestions. Regards, Andy -----Original Message----- From: Tomasz Figa [mailto:tfiga@xxxxxxxxxxxx] Sent: Friday, March 2, 2018 11:44 PM To: Yeh, Andy <andy.yeh@xxxxxxxxx> Cc: Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx>; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; Chen, JasonX Z <jasonx.z.chen@xxxxxxxxx>; Chiang, AlanX <alanx.chiang@xxxxxxxxx> Subject: Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver Hi Andy, Thanks for the patch. Let me post some comments inline. On Fri, Mar 2, 2018 at 11:55 PM, Andy Yeh <andy.yeh@xxxxxxxxx> wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Jason Chen <jasonx.z.chen@xxxxxxxxx> > Signed-off-by: Alan Chiang <alanx.chiang@xxxxxxxxx> > --- > since v2: > -- Update the streaming function to remove SW_STANDBY in the beginning. > -- Adjust the delay time from 1ms to 12ms before set stream-on register. > since v3: > -- fix the sd.entity to make code be compiled on the mainline kernel. > since v4: > -- Enabled AG, DG, and Exposure time control correctly. > since v5: > -- Sensor vendor provided a new setting to fix different CLK issue > -- Add one more resolution for 1048x780, used for VGA streaming
