Hi Fabio, On Wed, Mar 07, 2018 at 06:51:26AM -0300, Fabio Estevam wrote: > Hi Sakari, > > On Wed, Mar 7, 2018 at 5:13 AM, Sakari Ailus <sakari.ailus@xxxxxx> wrote: > > >> @@ -2497,16 +2504,22 @@ static int ov5640_probe(struct i2c_client *client, > >> struct fwnode_handle *endpoint; > >> struct ov5640_dev *sensor; > >> int ret; > >> + struct v4l2_mbus_framefmt *fmt; > > > > This one I'd arrange before ret. The local variable declarations should > > generally look like a Christmas tree but upside down. > > It seems Mauro is not happy with reverse Christmas tree ordering: > https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg127221.html There are other arguments supporting the change such as: - alignment with the rest of the driver and - putting similar definitions together (return value vs. pointers somewhere else). -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx
