Re: [PATCH] media: ov772x: constify ov772x_frame_intervals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote:
> The values on this array never changes. Make it const.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>

Acked-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>

Since I'm sure there will be more cleanup/fixes on tw9910 and ov772x,
could you please take into account my series:
[PATCH v2 00/11] media: ov772x/tw9910 cleanup
before any additional change to these 2 drivers?

Thanks
   j
> ---
>  drivers/media/i2c/ov772x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> index 16665af0c712..321105bb3161 100644
> --- a/drivers/media/i2c/ov772x.c
> +++ b/drivers/media/i2c/ov772x.c
> @@ -531,7 +531,7 @@ static const struct ov772x_win_size ov772x_win_sizes[] = {
>  /*
>   * frame rate settings lists
>   */
> -static unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
> +static const unsigned int ov772x_frame_intervals[] = { 5, 10, 15, 20, 30, 60 };
>
>  /*
>   * general function
> --
> 2.14.3
>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux