Hi Niklas, On Thu, Mar 01, 2018 at 05:13:38PM +0100, Niklas Söderlund wrote: > On 2018-03-01 12:30:47 +0100, Maxime Ripard wrote: > > Here is an attempt at supporting the MIPI-CSI2 TX block from Cadence. > > > > This IP block is able to receive 4 video streams and stream them over > > a MIPI-CSI2 link using up to 4 lanes. Those streams are basically the > > interfaces to controllers generating some video signals, like a camera > > or a pattern generator. > > > > It is able to map input streams to CSI2 virtual channels and datatypes > > dynamically. The streaming devices choose their virtual channels > > through an additional signal that is transparent to the CSI2-TX. The > > datatypes however are yet another additional input signal, and can be > > mapped to any CSI2 datatypes. > > > > Since v4l2 doesn't really allow for that setup at the moment, this > > preliminary version is a rather dumb one in order to start the > > discussion on how to address this properly. > > I'm sure you already are aware of this but in case you are not. Sakari > have a branch [1] which addresses much of the CSI-2 virtual channel > problems. It handles data types, virtual channels and format validation > for pipelines in IMHO good way. I have used it for my base when > implementing the R-Car CSI-2 receiver which adds a proposed way on how > to start and stop streams using Sakaris work [2]. > > Would it be possible for you to try this series on-top of Sakaris branch > and see if it fits your needs? I would be happy if it did and we can > start the process of trying to get his work upstream so we can clear > that dependency for our hopefully shared problem :-) Thanks for pointing this out :) I already started to look into this a few weeks back, and while it's not yet feature complete, it seemed to work quite well for the RX case. I haven't had time to test it on the TX controller yet. So I'd say that for now, his patches look enough to me :) Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
