The CSTRST_CPON mask was wrongly assigned to BIT(1) instead of BIT(0). Fix that by changing the mask opportunely. Reported-by: Dylan Laduranty <dylan.laduranty@xxxxxxxxxxx> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> --- Mauro: could you please pick up this patch since you already applied the CEU series to your tree if I'm not wrong? Laurent, in this email exchange: https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg123779.html you asked me to measure the number of cycles required to fully reset the interface in order to quantify the proper delay loops. I was testing this using the wrong bit, and I always got 0, and I assumed 1usec was enough. Good news is that I re-tested this on SH and RZ and I still have 0, so no driver change is required apart from the bitmask one \o/ --- drivers/media/platform/renesas-ceu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c index cfabe1a..c7d3659 100644 --- a/drivers/media/platform/renesas-ceu.c +++ b/drivers/media/platform/renesas-ceu.c @@ -95,7 +95,7 @@ /* CEU operating flag bit. */ #define CEU_CAPCR_CTNCP BIT(16) -#define CEU_CSTRST_CPTON BIT(1) +#define CEU_CSTRST_CPTON BIT(0) /* Platform specific IRQ source flags. */ #define CEU_CETCR_ALL_IRQS_RZ 0x397f313 -- 2.7.4
