Re: [PATCH] media: ttpci/ttusb: add extra parameter to filter callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc3 next-20180223]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-ttpci-ttusb-add-extra-parameter-to-filter-callbacks/20180226-144150
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x004-201808 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/media/pci/ttpci/av7110_av.c: In function 'av7110_record_cb':
>> drivers/media/pci/ttpci/av7110_av.c:101:10: error: too many arguments to function 'dvbdmxfeed->cb.ts'
      return dvbdmxfeed->cb.ts(buf, len, NULL, 0,
             ^~~~~~~~~~
   drivers/media/pci/ttpci/av7110_av.c: In function 'dvb_filter_pes2ts_cb':
   drivers/media/pci/ttpci/av7110_av.c:111:2: error: too many arguments to function 'dvbdmxfeed->cb.ts'
     dvbdmxfeed->cb.ts(data, 188, NULL, 0,
     ^~~~~~~~~~
   drivers/media/pci/ttpci/av7110_av.c: In function 'p_to_t':
>> drivers/media/pci/ttpci/av7110_av.c:817:3: error: too many arguments to function 'feed->cb.ts'
      feed->cb.ts(obuf, 188, NULL, 0, &feed->feed.ts, NULL);
      ^~~~
--
   drivers/media/pci/ttpci/av7110.c: In function 'DvbDmxFilterCallback':
>> drivers/media/pci/ttpci/av7110.c:325:10: error: too many arguments to function 'dvbdmxfilter->feed->cb.sec'
      return dvbdmxfilter->feed->cb.sec(buffer1, buffer1_len,
             ^~~~~~~~~~~~
>> drivers/media/pci/ttpci/av7110.c:332:11: error: too many arguments to function 'dvbdmxfilter->feed->cb.ts'
       return dvbdmxfilter->feed->cb.ts(buffer1, buffer1_len,
              ^~~~~~~~~~~~

vim +101 drivers/media/pci/ttpci/av7110_av.c

^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   90  
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   91  
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   92  int av7110_record_cb(struct dvb_filter_pes2ts *p2t, u8 *buf, size_t len)
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   93  {
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   94  	struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) p2t->priv;
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   95  
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   96  	if (!(dvbdmxfeed->ts_type & TS_PACKET))
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   97  		return 0;
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   98  	if (buf[3] == 0xe0)	 // video PES do not have a length in TS
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16   99  		buf[4] = buf[5] = 0;
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16  100  	if (dvbdmxfeed->ts_type & TS_PAYLOAD_ONLY)
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16 @101  		return dvbdmxfeed->cb.ts(buf, len, NULL, 0,
daaf9302 drivers/media/pci/ttpci/av7110_av.c Mauro Carvalho Chehab 2018-02-23  102  					 &dvbdmxfeed->feed.ts, NULL);
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16  103  	else
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16  104  		return dvb_filter_pes2ts(p2t, buf, len, 1);
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16  105  }
^1da177e drivers/media/dvb/ttpci/av7110_av.c Linus Torvalds        2005-04-16  106  

:::::: The code at line 101 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux