Hi Steve, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc2 next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Steve-Longerbeam/media-imx-Switch-to-subdev-notifiers/20180223-120401 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-n0-201807 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): drivers/media//platform/video-mux.c: In function 'video_mux_async_register': >> drivers/media//platform/video-mux.c:215:10: error: implicit declaration of function 'kcalloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration] ports = kcalloc(num_pads - 1, sizeof(*ports), GFP_KERNEL); ^~~~~~~ d_alloc >> drivers/media//platform/video-mux.c:215:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion] ports = kcalloc(num_pads - 1, sizeof(*ports), GFP_KERNEL); ^ >> drivers/media//platform/video-mux.c:225:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] kfree(ports); ^~~~~ vfree cc1: some warnings being treated as errors vim +215 drivers/media//platform/video-mux.c 208 209 static int video_mux_async_register(struct video_mux *vmux, 210 unsigned int num_pads) 211 { 212 unsigned int i, *ports; 213 int ret; 214 > 215 ports = kcalloc(num_pads - 1, sizeof(*ports), GFP_KERNEL); 216 if (!ports) 217 return -ENOMEM; 218 for (i = 0; i < num_pads - 1; i++) 219 ports[i] = i; 220 221 ret = v4l2_async_register_fwnode_subdev( 222 &vmux->subdev, sizeof(struct v4l2_async_subdev), 223 ports, num_pads - 1, video_mux_parse_endpoint); 224 > 225 kfree(ports); 226 return ret; 227 } 228 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
