On 02/21/18 16:16, jacopo mondi wrote:
>>> static const struct v4l2_subdev_pad_ops ov772x_subdev_pad_ops = {
>>> - .enum_mbus_code = ov772x_enum_mbus_code,
>>> - .get_selection = ov772x_get_selection,
>>> - .get_fmt = ov772x_get_fmt,
>>> - .set_fmt = ov772x_set_fmt,
>>> + .enum_frame_interval = ov772x_enum_frame_interval,
>>> + .enum_mbus_code = ov772x_enum_mbus_code,
>>> + .get_selection = ov772x_get_selection,
>>> + .get_fmt = ov772x_get_fmt,
>>> + .set_fmt = ov772x_set_fmt,
>>
>> Shouldn't these last four ops be added in the previous patch?
>> They don't have anything to do with the frame interval support.
>>
>
> If you look closely you'll notice I have just re-aligned them, since I
> was at there to add enum_frame_interval operation
Ah, sorry. I missed that. Never mind then :-)
Hans
>
>> Anyway, after taking care of the memsets and these four ops you can add
>> my:
>>
>> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> Thanks
> j
>
