On 02/16/2018 12:58 PM, Mauro Carvalho Chehab wrote: > Em Fri, 16 Feb 2018 11:04:36 +0200 > Sakari Ailus <sakari.ailus@xxxxxx> escreveu: > >> On Wed, Feb 14, 2018 at 02:14:30PM -0200, Mauro Carvalho Chehab wrote: >>> Sakari, >>> >>> Em Mon, 22 Jan 2018 13:31:19 +0100 >>> Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: >>> >>>> From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >>>> >>>> Remove sensor driver's interface that made use of use case specific >>>> knowledge of platform capabilities. >>> >>> Could you better describe it? What s_param abuse? >>> What happens after this patch? It seems that atomISP relies on >> >> I'd like to remind you this is a staging driver that got where it is >> without any review. > > Ok, but this is not an excuse to not properly document any further > patches to it. > >> If you insist on improving the commit message, then >> this is what I propose: >> >> Remove sensor driver's interface for setting the use case specific mode >> list as well as the mode lists that are related to other than >> CI_MODE_PREVIEW. This removes s_parm abuse in using driver specific values >> in v4l2_streamparm.capture.capturemode. The drivers already support >> [gs]_frame_interval so removing support for [gs]_parm is enough. > > Works for me. I'll update the commit message for this patch. Regards, Hans
