Re: [PATCH V2 0/3] Add timers to en50221 protocol driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jasmin,

Jasmin J. writes:
 > Hi!
 > 
 > Please hold on in merging this series, because I have to investigate a hint
 > I got related to the buffer size handshake of the protocol driver:
 >   https://www.linuxtv.org/pipermail/linux-dvb/2007-July/019116.html
 > 
 > BR,
 >    Jasmin


So, there seem to be two bugs:

1. The SW bit is cleared too early during the whole buffer size negotiation.

This should be fixed.


2. IRQEN = CMDREG_DAIE = 0x80 is always set in the command register.

DAIE and FRIE were introduced as recommendation in Cenelec R06-001:1998 and are a requirement for
CI+.

They could cause problems if the IRQ line goes high and the interrupt is enabled but not handled.
They should not cause a problem if the host ignores the interrupt or if the CAM does not support it,
but one never knows with some CAMs ...

So, they should probably only be used if both the host and module say they support it.
R06 does not mention it but CI+ also requires a CIS entry to be present in modules 
supporting this feature.



Regards,
Ralph



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux