Em Mon, 22 Jan 2018 13:31:20 +0100
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
>
> Disable configurations for non-preview modes until configuration selection
> is improved.
Again, a poor description. It just repeats the subject.
A good subject/description should answer 3 questions:
what?
why?
how?
Anyway, looking at this patch's contents, it partially answers my
questions:
the previous patch do cause regressions at the code.
Ok, this is staging. So, we don't have very strict rules here,
but still causing regressions without providing a very good
reason why sucks.
I would also merge this with the previous one, in order to place all
regressions on a single patch.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
> drivers/staging/media/atomisp/i2c/gc2235.h | 2 ++
> drivers/staging/media/atomisp/i2c/ov2722.h | 2 ++
> drivers/staging/media/atomisp/i2c/ov5693/ov5693.h | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h
> index 45a54fea5466..817c0068c1d3 100644
> --- a/drivers/staging/media/atomisp/i2c/gc2235.h
> +++ b/drivers/staging/media/atomisp/i2c/gc2235.h
> @@ -574,6 +574,7 @@ static struct gc2235_resolution gc2235_res_preview[] = {
> };
> #define N_RES_PREVIEW (ARRAY_SIZE(gc2235_res_preview))
>
> +#if 0 /* Disable non-previes configurations for now */
typo (here and other cut-and-paste paces)
non-previes -> non-previews
also, please add a FIXME: or HACK: and describe the need for a fix
on atomisp TODO file.
> static struct gc2235_resolution gc2235_res_still[] = {
> {
> .desc = "gc2235_1600_900_30fps",
> @@ -658,6 +659,7 @@ static struct gc2235_resolution gc2235_res_video[] = {
>
> };
> #define N_RES_VIDEO (ARRAY_SIZE(gc2235_res_video))
> +#endif
>
> static struct gc2235_resolution *gc2235_res = gc2235_res_preview;
> static unsigned long N_RES = N_RES_PREVIEW;
> diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
> index d8a973d71699..f133439adfd5 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2722.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2722.h
> @@ -1148,6 +1148,7 @@ struct ov2722_resolution ov2722_res_preview[] = {
> };
> #define N_RES_PREVIEW (ARRAY_SIZE(ov2722_res_preview))
>
> +#if 0 /* Disable non-previes configurations for now */
> struct ov2722_resolution ov2722_res_still[] = {
> {
> .desc = "ov2722_480P_30fps",
> @@ -1250,6 +1251,7 @@ struct ov2722_resolution ov2722_res_video[] = {
> },
> };
> #define N_RES_VIDEO (ARRAY_SIZE(ov2722_res_video))
> +#endif
>
> static struct ov2722_resolution *ov2722_res = ov2722_res_preview;
> static unsigned long N_RES = N_RES_PREVIEW;
> diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h
> index 68cfcb4a6c3c..15a33dcd2d59 100644
> --- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h
> +++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h
> @@ -1147,6 +1147,7 @@ struct ov5693_resolution ov5693_res_preview[] = {
> };
> #define N_RES_PREVIEW (ARRAY_SIZE(ov5693_res_preview))
>
> +#if 0 /* Disable non-previes configurations for now */
> struct ov5693_resolution ov5693_res_still[] = {
> {
> .desc = "ov5693_736x496_30fps",
> @@ -1364,6 +1365,7 @@ struct ov5693_resolution ov5693_res_video[] = {
> },
> };
> #define N_RES_VIDEO (ARRAY_SIZE(ov5693_res_video))
> +#endif
>
> static struct ov5693_resolution *ov5693_res = ov5693_res_preview;
> static unsigned long N_RES = N_RES_PREVIEW;
Thanks,
Mauro
