On Fri, Feb 09, 2018 at 01:20:41PM +0100, Hans Verkuil wrote: > On 02/09/18 13:17, Sakari Ailus wrote: > > On Thu, Feb 08, 2018 at 09:36:51AM +0100, Hans Verkuil wrote: > >> MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc > >> struct. Do so in media_device_setup_link(). > >> > >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > >> --- > >> drivers/media/media-device.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > >> index e79f72b8b858..afbf23a19e16 100644 > >> --- a/drivers/media/media-device.c > >> +++ b/drivers/media/media-device.c > >> @@ -218,6 +218,8 @@ static long media_device_setup_link(struct media_device *mdev, > >> if (link == NULL) > >> return -EINVAL; > >> > >> + memset(linkd->reserved, 0, sizeof(linkd->reserved)); > >> + > > > > Doesn't media_device_enum_links() need the same for its reserved field? > > enum_links() already zeroes this (actually the whole media_link_desc struct is zeroed). I can't see that being done in here and I also don't mean the compat variant. Can you point me to it? -- Sakari Ailus e-mail: sakari.ailus@xxxxxx
