Re: [PATCH] media: cxusb, dib0700: ignore XC2028_I2C_FLUSH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



thank you very very much!!
Hoping this patch find it's way into mainline ASAP! :)
It will make my life much easier, when dealing with systems with long uptime especially.


Enrico


On Wed, 24 Jan 2018, Mauro Carvalho Chehab wrote:

Date: Wed, 24 Jan 2018 12:05:24
From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
To: Enrico Mioso <mrkiko.rs@xxxxxxxxx>,
    Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx>,
    Jonathan Corbet <corbet@xxxxxxx>
Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>,
    Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>,
    Linux Doc Mailing List <linux-doc@xxxxxxxxxxxxxxx>,
    Michael Krufky <mkrufky@xxxxxxxxxxx>, Sean Young <sean@xxxxxxxx>,
    Hans Verkuil <hans.verkuil@xxxxxxxxx>,
    Andrey Konovalov <andreyknvl@xxxxxxxxxx>,
    Piotr Oleszczyk <piotr.oleszczyk@xxxxxxxxx>,
    Alexey Dobriyan <adobriyan@xxxxxxxxx>
Subject: [PATCH] media: cxusb, dib0700: ignore XC2028_I2C_FLUSH

The XC2028_I2C_FLUSH only needs to be implemented on a few
devices. Others can safely ignore it.

That prevents filling the dmesg with lots of messages like:

	dib0700: stk7700ph_xc3028_callback: unknown command 2, arg 0

Reported-by: Enrico Mioso <mrkiko.rs@xxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
---
drivers/media/usb/dvb-usb/cxusb.c           | 2 ++
drivers/media/usb/dvb-usb/dib0700_devices.c | 1 +
2 files changed, 3 insertions(+)

diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c
index 37dea0adc695..cfe86b4864b3 100644
--- a/drivers/media/usb/dvb-usb/cxusb.c
+++ b/drivers/media/usb/dvb-usb/cxusb.c
@@ -677,6 +677,8 @@ static int dvico_bluebird_xc2028_callback(void *ptr, int component,
	case XC2028_RESET_CLK:
		deb_info("%s: XC2028_RESET_CLK %d\n", __func__, arg);
		break;
+	case XC2028_I2C_FLUSH:
+		break;
	default:
		deb_info("%s: unknown command %d, arg %d\n", __func__,
			 command, arg);
diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c
index 366b05529915..a9968fb1e8e4 100644
--- a/drivers/media/usb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
@@ -430,6 +430,7 @@ static int stk7700ph_xc3028_callback(void *ptr, int component,
		state->dib7000p_ops.set_gpio(adap->fe_adap[0].fe, 8, 0, 1);
		break;
	case XC2028_RESET_CLK:
+	case XC2028_I2C_FLUSH:
		break;
	default:
		err("%s: unknown command %d, arg %d\n", __func__,
--
2.14.3





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux