On Thu, Jan 25, 2018 at 05:36:44PM +0000, Rapolu, Chiranjeevi wrote: > Hi Sakari, > > >I'll apply this now, however I see that most of the registers in the > > four modes are the same. In the future it'd be good to separate the > > parts that are common in all of them (to be written in sensor power-on) > > to make this (slightly) more maintainable. > > Thanks for the review. Makes sense. Not sure how it impacts because the > sequence of writes will be different, need thorough testing to confirm > nothing is broken. Yeah, that's a fair consideration. Most registers still have no side effects apart of streaming control or such. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx