Em Sun, 28 Jan 2018 01:18:57 +0200 Sakari Ailus <sakari.ailus@xxxxxx> escreveu: > Hi Hans, > ... > > + > > + if (ops->vidioc_query_ext_ctrl) > > + ret = ops->vidioc_query_ext_ctrl(file, fh, &qec); > > Is there a need for this? > > The only driver implementing vidioc_query_ext_ctrl op is the uvcvideo > driver --- and it does not support string controls. Well, one day, it could be added there, or some other driver may need to implement it. So, better safe than sorry. I would keep it (either as-is or with your suggestion) Cheers, Mauro