Re: [PATCH v3 0/3] media: ov9650: support device tree probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 21, 2018 at 05:33:14PM +0100, jacopo mondi wrote:
> Hello Akinobu,
> 
> On Mon, Jan 22, 2018 at 12:14:13AM +0900, Akinobu Mita wrote:
> > This patchset adds device tree probing for ov9650 driver. This contains
> > an actual driver change and a newly added binding documentation part.
> >
> > * Changelog v3
> > - Add Reviewed-by: tags
> > - Add MAINTAINERS entry
> >
> > * Changelog v2
> > - Split binding documentation, suggested by Rob Herring and Jacopo Mondi
> > - Improve the wording for compatible property in the binding documentation,
> >   suggested by Jacopo Mondi
> > - Improve the description for the device node in the binding documentation,
> >   suggested by Sakari Ailus
> > - Remove ov965x_gpio_set() helper and open-code it, suggested by Jacopo Mondi
> >   and Sakari Ailus
> > - Call clk_prepare_enable() in s_power callback instead of probe, suggested
> >   by Sakari Ailus
> > - Unify clk and gpio configuration in a single if-else block and, also add
> >   a check either platform data or fwnode is actually specified, suggested
> >   by Jacopo Mondi
> > - Add CONFIG_OF guards, suggested by Jacopo Mondi
> >
> > Akinobu Mita (3):
> >   media: ov9650: support device tree probing
> >   media: MAINTAINERS: add entry for ov9650 driver
> >   media: ov9650: add device tree binding
> 
> As you've closed my comments on v1/v2, for driver and device tree bindings:
> 
> Reviewed-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> 
> No need to resend just to add the tags, but in case you have to, please
> add them.

Thanks, guys!

Applied in order 2, 3 and 1 --- the DT changes come before driver changes.

-- 
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux