Hi Smitha, Thank you for this v6 series! You can add my: Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> to patches 1-9 and 11. See my review for patches 10 and 12. The comments are minor, so I hope I can Ack v7 once it's posted and this can be merged for 4.17. Regards, Hans On 08/12/17 10:08, Smitha T Murthy wrote: > This patch series adds MFC v10.10 support. MFC v10.10 is used in some > of Exynos7 variants. > > This adds support for following: > > * Add support for HEVC encoder and decoder > * Add support for VP9 decoder > * Update Documentation for control id definitions > * Update computation of min scratch buffer size requirement for V8 onwards > > Changes since v5: > - Addressed review comments by Kamil Debski <kamil@xxxxxxxxx>. > - Addressed review comments by > Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>. > - Addressed review comments by Hans Verkuil <hverkuil@xxxxxxxxx>. > - Rebased on latest git://linuxtv.org/snawrocki/samsung.git > for-v4.15/media/next. > - Applied r-o-b from Andrzej, Stanimir on respective patches. > - Applied acked-by from Kamil, Hans on respective patches. > > Smitha T Murthy (12): > [media] s5p-mfc: Rename IS_MFCV8 macro > [media] s5p-mfc: Adding initial support for MFC v10.10 > [media] s5p-mfc: Use min scratch buffer size as provided by F/W > [media] s5p-mfc: Support MFCv10.10 buffer requirements > [media] videodev2.h: Add v4l2 definition for HEVC > [media] v4l2-ioctl: add HEVC format description > Documentation: v4l: Documentation for HEVC v4l2 definition > [media] s5p-mfc: Add support for HEVC decoder > [media] s5p-mfc: Add VP9 decoder support > [media] v4l2: Add v4l2 control IDs for HEVC encoder > [media] s5p-mfc: Add support for HEVC encoder > Documention: v4l: Documentation for HEVC CIDs > > .../devicetree/bindings/media/s5p-mfc.txt | 1 + > Documentation/media/uapi/v4l/extended-controls.rst | 395 +++++++++++++++ > Documentation/media/uapi/v4l/pixfmt-compressed.rst | 5 + > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 88 ++++ > drivers/media/platform/s5p-mfc/regs-mfc-v8.h | 2 + > drivers/media/platform/s5p-mfc/s5p_mfc.c | 28 ++ > drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v6.c | 9 + > drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 68 ++- > drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 6 +- > drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 48 +- > drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 555 ++++++++++++++++++++- > drivers/media/platform/s5p-mfc/s5p_mfc_opr.h | 14 + > drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 397 +++++++++++++-- > drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h | 15 + > drivers/media/v4l2-core/v4l2-ctrls.c | 118 +++++ > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/v4l2-controls.h | 92 +++- > include/uapi/linux/videodev2.h | 1 + > 18 files changed, 1765 insertions(+), 78 deletions(-) > create mode 100644 drivers/media/platform/s5p-mfc/regs-mfc-v10.h >