On 22/01/18 11:28, Sakari Ailus wrote:
> On Mon, Jan 22, 2018 at 11:18:49AM +0100, Hans Verkuil wrote:
>> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>>
>> Create helpers to handle VIDIOC_G/S_PARM by querying the
>> g/s_frame_interval v4l2_subdev ops.
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>> ---
>> drivers/media/v4l2-core/v4l2-common.c | 49 +++++++++++++++++++++++++++++++++++
>> include/media/v4l2-common.h | 26 +++++++++++++++++++
>> 2 files changed, 75 insertions(+)
>>
>> diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
>> index 8650ad92b64d..4e371ae4aed7 100644
>> --- a/drivers/media/v4l2-core/v4l2-common.c
>> +++ b/drivers/media/v4l2-core/v4l2-common.c
>> @@ -392,3 +392,52 @@ void v4l2_get_timestamp(struct timeval *tv)
>> tv->tv_usec = ts.tv_nsec / NSEC_PER_USEC;
>> }
>> EXPORT_SYMBOL_GPL(v4l2_get_timestamp);
>> +
>> +int v4l2_g_parm_cap(struct video_device *vdev,
>> + struct v4l2_subdev *sd, struct v4l2_streamparm *a)
>> +{
>> + struct v4l2_subdev_frame_interval ival = { 0 };
>> + int ret;
>> +
>> + if (a->type != V4L2_BUF_TYPE_VIDEO_CAPTURE &&
>> + a->type != V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
>> + return -EINVAL;
>> +
>> + if (vdev->device_caps & V4L2_CAP_READWRITE)
>> + a->parm.capture.readbuffers = 2;
>> + if (v4l2_subdev_has_op(sd, video, g_frame_interval))
>> + a->parm.capture.capability = V4L2_CAP_TIMEPERFRAME;
>> + ret = v4l2_subdev_call(sd, video, g_frame_interval, &ival);
>> + if (!ret)
>> + a->parm.capture.timeperframe = ival.interval;
>> + return ret;
>> +}
>> +EXPORT_SYMBOL_GPL(v4l2_g_parm_cap);
>> +
>> +int v4l2_s_parm_cap(struct video_device *vdev,
>> + struct v4l2_subdev *sd, struct v4l2_streamparm *a)
>> +{
>> + struct v4l2_subdev_frame_interval ival = {
>> + 0,
>> + a->parm.capture.timeperframe
>
> I'd explicitly specify which members are assigned here. It looks cleaner
> and does not depend on field order in the struct definition. It won't be
> changed as it's part of uAPI but then again people take examples from
> existing code and could do this where it's not safe.
True. I'll change this.
Regards,
Hans
