Assign ret in the default case for s_ctrl callback. This can't happen but still may result in compiler warnings. Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> --- drivers/media/i2c/ov2685.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov2685.c b/drivers/media/i2c/ov2685.c index df4abecd8d74..904ac305d499 100644 --- a/drivers/media/i2c/ov2685.c +++ b/drivers/media/i2c/ov2685.c @@ -574,6 +574,7 @@ static int ov2685_set_ctrl(struct v4l2_ctrl *ctrl) default: dev_warn(&client->dev, "%s Unhandled id:0x%x, val:0x%x\n", __func__, ctrl->id, ctrl->val); + ret = -EINVAL; break; }; -- 2.11.0