Hello, I was growing tired of explaining during review that, while the uvcvideo.h header used the extern keyword in front of function declarations, the same style mistake didn't have to be copied in all patches. I thus decided to write patch 1/4, and while at it I fixed similar style issues in patch 2/4 to 4/4. Apart from the kmalloc() to kmalloc_array() change, a byte-to-byte comparison of the .text sections of the module shows no difference before and after this series. Laurent Pinchart (4): uvcvideo: Drop extern keyword in function declarations uvcvideo: Use kernel integer types uvcvideo: Use internal kernel integer types uvcvideo: Use parentheses around sizeof operand drivers/media/usb/uvc/uvc_ctrl.c | 62 +++---- drivers/media/usb/uvc/uvc_driver.c | 97 +++++------ drivers/media/usb/uvc/uvc_isight.c | 6 +- drivers/media/usb/uvc/uvc_status.c | 4 +- drivers/media/usb/uvc/uvc_v4l2.c | 76 ++++----- drivers/media/usb/uvc/uvc_video.c | 42 ++--- drivers/media/usb/uvc/uvcvideo.h | 321 ++++++++++++++++++------------------- 7 files changed, 303 insertions(+), 305 deletions(-) -- Regards, Laurent Pinchart
