On Tue, Jan 16, 2018 at 4:44 PM, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: >> if (camif_mbus_formats[i] == mf->code) >> break; >> >> + if (i == ARRAY_SIZE(camif_mbus_formats)) >> + mf->code = camif_mbus_formats[0]; >> + > > Either else here so that the line below is executed only if the condition > is false, or assign i = 0 above. Otherwise you'll end up with a different > off-by-one bug. :-) Oops. Sent v3 now, thanks for the review. Arnd