Hi, Tomasz, Thanks for reviewing the patch. > -----Original Message----- > From: Tomasz Figa [mailto:tfiga@xxxxxxxxxxxx] > Sent: Friday, January 12, 2018 12:19 AM > To: Zhi, Yong <yong.zhi@xxxxxxxxx> > Cc: Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx>; Sakari Ailus > <sakari.ailus@xxxxxxxxxxxxxxx>; Mani, Rajmohan > <rajmohan.mani@xxxxxxxxx>; Cao, Bingbu <bingbu.cao@xxxxxxxxx> > Subject: Re: [PATCH 2/2] media: intel-ipu3: cio2: fix for wrong vb2buf state > warnings > > On Thu, Jan 4, 2018 at 11:57 AM, Yong Zhi <yong.zhi@xxxxxxxxx> wrote: > > cio2 driver should release buffer with QUEUED state when start_stream > > op failed, wrong buffer state will cause vb2 core throw a warning. > > > > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx> > > Signed-off-by: Cao Bing Bu <bingbu.cao@xxxxxxxxx> > > --- > > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > index 949f43d206ad..106d04306372 100644 > > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > @@ -785,7 +785,8 @@ static irqreturn_t cio2_irq(int irq, void > > *cio2_ptr) > > > > /**************** Videobuf2 interface ****************/ > > > > -static void cio2_vb2_return_all_buffers(struct cio2_queue *q) > > +static void cio2_vb2_return_all_buffers(struct cio2_queue *q, > > + enum vb2_buffer_state state) > > { > > unsigned int i; > > > > @@ -793,7 +794,7 @@ static void cio2_vb2_return_all_buffers(struct > cio2_queue *q) > > if (q->bufs[i]) { > > atomic_dec(&q->bufs_queued); > > vb2_buffer_done(&q->bufs[i]->vbb.vb2_buf, > > - VB2_BUF_STATE_ERROR); > > + state); > > nit: Does it really exceed 80 characters after folding into previous line? > Thanks for catching this, seems this patch was merged, may I fix it in future patch? > With the nit fixed: > Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx> > > Best regards, > Tomasz
