Hi Maxime, On Thu, 11 Jan 2018 14:28:44 +0100 Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > Hi Yong, > > On Thu, Jan 11, 2018 at 11:06:06AM +0800, Yong Deng wrote: > > Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 > > interface and CSI1 is used for parallel interface. This is not > > documented in datasheet but by test and guess. > > > > This patch implement a v4l2 framework driver for it. > > > > Currently, the driver only support the parallel interface. MIPI-CSI2, > > ISP's support are not included in this patch. > > > > Signed-off-by: Yong Deng <yong.deng@xxxxxxxxxxxx> > > I've needed this patch in order to fix a NULL pointer dereference: > http://code.bulix.org/oz6gmb-257359?raw > > This is needed because while it's ok to have a NULL pointer to > v4l2_subdev_pad_config when you call the subdev set_fmt with > V4L2_SUBDEV_FORMAT_ACTIVE, it's not with V4L2_SUBDEV_FORMAT_TRY, and > sensors will assume taht it's a valid pointer. > > Otherwise, > Tested-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> I revisit some code of subdevs and you are right. Squash your patch into my driver patch and add your Tested-by in commit. Is it right? > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@xxxxxxxxxxxxxxxx. > For more options, visit https://groups.google.com/d/optout. Thanks, Yong
