Re: [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 10 Jan 2018 09:17:24 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1515530966.9619.124.camel@perches.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Jan 09, 2018 at 12:49:26PM -0800, Joe Perches wrote:
> This message doesn't make sense anymore and it might as well
> be deleted.
> 
> And it might be better to use kcalloc
> 
> 	ttusb->iso_buffer = kcalloc(FRAMES_PER_ISO_BUF * ISO_BUF_COUNT,
> 				    ISO_FRAME_SIZE, GFP_KERNEL);

Sure.

References:
- remove pci_dma_* abuses and workarounds
  - From: Christoph Hellwig
- [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse
  - From: Christoph Hellwig
- Re: [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse
  - From: Joe Perches

Prev by Date: Re: [PATCH 3/3] pci-dma-compat: remove handling of NULL pdev arguments
Next by Date: Re: [PATCH v5 2/4] media: ov5695: add support for OV5695 sensor
Previous by thread: Re: [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse
Next by thread: Re: [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse
Index(es):
- Date
- Thread

[Index of Archives] [Linux Input] [Video for Linux] [Gstreamer Embedded] [Mplayer Users] [Linux USB Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux