Hi Devin, On Thursday 26 November 2009 00:06:40 Devin Heitmueller wrote: > On Wed, Nov 18, 2009 at 7:54 AM, Laurent Pinchart > > <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > Hi everybody, > > > > the V4L cleanup patches are now available from > > > > http://linuxtv.org/hg/~pinchartl/v4l-dvb-cleanup > > > > The tree will be rebased if needed (or rather dropped and recreated as hg > > doesn't provide a rebase operation), so please don't pull from it yet if > > you don't want to have to throw the patches away manually later. > > > > I've incorporated the comments received so far and went through all the > > patches to spot bugs that could have sneaked in. > > > > Please test the code against the driver(s) you maintain. The changes are > > small, *should* not create any issue, but the usual bug can still sneak > > in. > > > > I can't wait for an explicit ack from all maintainers (mostly because I > > don't know you all), so I'll send a pull request in a week if there's no > > blocking issue. I'd like this to get in 2.6.33 if possible. > > > > -- > > Regards, > > > > Laurent Pinchart > > Hi Laurent, > > Well, I don't know what is wrong yet, but the au0828 driver now hits > an OOPS with this tree whenever the device is disconnected, whereas > with last night's v4l-dvb tip it was working fine. > > I'll dig into it now... Thank you very much for the report. Could you please try with the following patch applied on top of the v4l-dvb-cleanup tree ? diff -r 98e3929a1a2d linux/drivers/media/video/au0828/au0828-video.c --- a/linux/drivers/media/video/au0828/au0828-video.c Wed Nov 25 12:55:47 2009 +0100 +++ b/linux/drivers/media/video/au0828/au0828-video.c Thu Nov 26 01:02:15 2009 +0100 @@ -697,10 +697,8 @@ dprintk(1, "au0828_release_resources called\n"); mutex_lock(&au0828_sysfs_lock); - if (dev->vdev) { - list_del(&dev->au0828list); + if (dev->vdev) video_unregister_device(dev->vdev); - } if (dev->vbi_dev) video_unregister_device(dev->vbi_dev); @@ -1671,7 +1669,6 @@ if (retval != 0) { dprintk(1, "unable to register video device (error = %d).\n", retval); - list_del(&dev->au0828list); video_device_release(dev->vdev); return -ENODEV; } @@ -1683,7 +1680,6 @@ if (retval != 0) { dprintk(1, "unable to register vbi device (error = %d).\n", retval); - list_del(&dev->au0828list); video_device_release(dev->vbi_dev); video_device_release(dev->vdev); return -ENODEV; diff -r 98e3929a1a2d linux/drivers/media/video/au0828/au0828.h --- a/linux/drivers/media/video/au0828/au0828.h Wed Nov 25 12:55:47 2009 +0100 +++ b/linux/drivers/media/video/au0828/au0828.h Thu Nov 26 01:02:15 2009 +0100 @@ -192,7 +192,6 @@ struct au0828_dvb dvb; /* Analog */ - struct list_head au0828list; struct v4l2_device v4l2_dev; int users; unsigned int stream_on:1; /* Locks streams */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
