Hi Jacopo,
On Mon, Jan 08, 2018 at 10:18:38AM +0100, jacopo mondi wrote:
> > @@ -1561,9 +1605,19 @@ static const struct i2c_device_id ov965x_id[] = {
> > };
> > MODULE_DEVICE_TABLE(i2c, ov965x_id);
> >
> > +#if IS_ENABLED(CONFIG_OF)
> > +static const struct of_device_id ov965x_of_match[] = {
> > + { .compatible = "ovti,ov9650", },
> > + { .compatible = "ovti,ov9652", },
> > + { /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, ov965x_of_match);
> > +#endif
> > +
> > static struct i2c_driver ov965x_i2c_driver = {
> > .driver = {
> > .name = DRIVER_NAME,
> > + .of_match_table = of_match_ptr(ov965x_of_match),
>
> If CONFIG_OF is not defined, this will break compilation.
> Please guard this with #if IS_ENABLED(CONFIG_OF) as well.
of_match_ptr() will be NULL if CONFIG_OF is not defined, so AFAICT this is
fine.
--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
