On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > @@ -914,9 +904,7 @@ static int lm3554_probe(struct i2c_client *client) > dev_err(&client->dev, "gpio request/direction_output fail"); > goto fail2; > } > - if (ACPI_HANDLE(&client->dev)) > - err = atomisp_register_i2c_module(&flash->sd, NULL, LED_FLASH); > - return 0; > + return atomisp_register_i2c_module(&flash->sd, NULL, LED_FLASH); > fail2: > media_entity_cleanup(&flash->sd.entity); > v4l2_ctrl_handler_free(&flash->ctrl_handler); Actually every place where we directly return a function call is wrong and needs error handling added. I've been meaning to write a Smatch check for this because it's a common anti-pattern we don't check the last function call for errors. Someone could probably do the same in Coccinelle if they want. regards, dan carpenter
