Hi Akinobu, On Wed, Dec 20, 2017 at 12:39:51AM +0900, Akinobu Mita wrote: > Hi Sakari, > > 2017-12-19 19:35 GMT+09:00 Sakari Ailus <sakari.ailus@xxxxxx>: > > Hi Akinobu, > > > > On Thu, Dec 14, 2017 at 01:00:49AM +0900, Akinobu Mita wrote: > >> This adds support VIDIOC_DBG_G/S_REGISTER ioctls. > >> > >> There are many device control registers contained in the OV9650. So > >> this helps debugging the lower level issues by getting and setting the > >> registers. > >> > >> Cc: Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> > >> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > >> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > >> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > > > > Just wondering --- doesn't the I涎 user space interface offer essentially > > the same functionality? > > You are right. I thought /dev/i2c-X interface is not allowed for the > i2c device that is currently in use by a driver. But I found that > there is I2C_SLAVE_FORCE ioctl to bypass the check and the i2cget and > i2cset with '-f' option use I2C_SLAVE_FORCE ioctls. > > So I can live without the proposed patch. Thanks for checking. It's indeed better to use an existing interface. There's also debugfs. That might be even better but it requires driver code to make use of it. Anyway non-I²C devices can use it, too. I'll mark the patch as rejected. -- Kind regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
