Em Tue, 10 Oct 2017 21:47:04 +0100
Andrey Utkin <andrey_utkin@xxxxxxxxxxxx> escreveu:
> On Mon, Oct 09, 2017 at 07:19:11AM -0300, Mauro Carvalho Chehab wrote:
> > Using enums makes easier to document, as it can use kernel-doc
> > markups. It also allows cross-referencing, with increases the
> > kAPI readability.
> >
>
>
> All changes look legit.
>
> But I'd expect cx88_querycap() return type change and such to be in
> separate commit.
It should be together, as the switch() now would generate a warning,
because some enum values aren't listed. On such case, it has to
return an error.
I added an explanation at the commit message.
>
> > diff --git a/drivers/media/pci/cx88/cx88-blackbird.c b/drivers/media/pci/cx88/cx88-blackbird.c
> > index e3101f04941c..0e0952e60795 100644
> > --- a/drivers/media/pci/cx88/cx88-blackbird.c
> > +++ b/drivers/media/pci/cx88/cx88-blackbird.c
> > @@ -805,8 +805,7 @@ static int vidioc_querycap(struct file *file, void *priv,
> >
> > strcpy(cap->driver, "cx88_blackbird");
> > sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));
> > - cx88_querycap(file, core, cap);
> > - return 0;
> > + return cx88_querycap(file, core, cap);
> > }
> >
> > static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv,
> > diff --git a/drivers/media/pci/cx88/cx88-video.c b/drivers/media/pci/cx88/cx88-video.c
> > index 7d25ecd4404b..9be682cdb644 100644
> > --- a/drivers/media/pci/cx88/cx88-video.c
> > +++ b/drivers/media/pci/cx88/cx88-video.c
> > @@ -806,8 +806,8 @@ static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
> > return 0;
> > }
> >
> > -void cx88_querycap(struct file *file, struct cx88_core *core,
> > - struct v4l2_capability *cap)
> > +int cx88_querycap(struct file *file, struct cx88_core *core,
> > + struct v4l2_capability *cap)
> > {
> > struct video_device *vdev = video_devdata(file);
> >
Thanks,
Mauro
